| Author |
|
AraCam
SOOP Admins
soop admins
Joined: 19 November 2004
 United States
Posts: 847
|
| Posted: 02 October 2009 at 1:58pm | IP Logged
|
|
|
I personally cannot confirm this, but one of my users says:
Quote: I've had problems with submitting posts and it only publishing part of the post. Its usually been when I'm typing a short post
(3-5 lines). And sometimes the reverse happens. Namely, I type a
longer post. Decide to delete part of it before I submit it. Chop out
a sentence or two, then post. Sometimes what gets posted is my post
before the deletions.
It's like the
site remembers what I've put down about a minute before I post it and
then it posts that older version, whether its that I've added stuff
later or deleted stuff later.
He's using IE 7
__________________
I'm a database admin. If you see me running, save your work!
{Cranial Herbs & Rice}
|
Back to Top  |
|
| |
Hooded
SOOP Admins
Joined: 09 April 2004
 Canada
Posts: 2118
|
| Posted: 03 October 2009 at 5:52am | IP Logged
|
|
|
Strange days have found us
__________________
The worlds worst speller. Thats why I bought ieSpell.
Now I just got to remember to use it [IMG]smileys/smiley18.gif" />
|
| Back to Top |
|
| |
Qmax
SOOP Admins
Joined: 30 May 2004
United States
Posts: 5289
|
| Posted: 03 October 2009 at 6:23am | IP Logged
|
|
|
Theyre going to destroy
Our casual joys
__________________
Because our goals are not lofty but illusory, our problems are not difficult, but nonsensical
|
| Back to Top |
|
| |
AraCam
SOOP Admins
soop admins
Joined: 19 November 2004
United States
Posts: 847
|
| Posted: 03 October 2009 at 7:32am | IP Logged
|
|
|
__________________
I'm a database admin. If you see me running, save your work!
{Cranial Herbs & Rice}
|
| Back to Top |
|
| |
ph4nt0m
SOOP Admins
Joined: 03 August 2005
 United Kingdom
Posts: 711
|
| Posted: 05 February 2010 at 8:26am | IP Logged
|
|
|
I'm getting the same reports from users, I tried to track down the source of this problem and think that it's actually an issue in TinyMCE itself,
Myself an Walter spent the best part of a day working with this an it appears that in TinyMCE, when you try ta add a line break mid post, it seems to enter a strange  character in between the <p> tags, as far as I can tell its this that is failing the submission of long posts, but sadly this is an Issue with TinyMCE, not our code,
Closing this as it really isnt a Phoenix Bug, lets hope it gets fixed in an update from Moxicode
__________________
"Microsoft Products are Generally Bug Free"
-- Bill Gates
|
| Back to Top |
|
| |
AraCam
SOOP Admins
soop admins
Joined: 19 November 2004
United States
Posts: 847
|
| Posted: 05 February 2010 at 9:00am | IP Logged
|
|
|
Has this been reported to the TinyMCE developers?
Is the crash happening before the post gets from TinyMCE to our ASP code or after? If it's after, then we could do a replace on that character maybe and trap it?
__________________
I'm a database admin. If you see me running, save your work!
{Cranial Herbs & Rice}
|
| Back to Top |
|
| |
AraCam
SOOP Admins
soop admins
Joined: 19 November 2004
United States
Posts: 847
|
| Posted: 05 February 2010 at 9:22am | IP Logged
|
|
|
Another thought, but TinyMCE's download page lists the current version as 3.3b2, released 2010-02-04. We are using TinyMCE v 3.2.6, released 2009-08-19.
Is it possible moving to the newer TinyMCE will resolve this?
__________________
I'm a database admin. If you see me running, save your work!
{Cranial Herbs & Rice}
|
| Back to Top |
|
| |
ph4nt0m
SOOP Admins
Joined: 03 August 2005
United Kingdom
Posts: 711
|
| Posted: 05 February 2010 at 11:28am | IP Logged
|
|
|
Walter will be adding Build 3.3b2 to the SVN tomorrow ready for a patch release :)
__________________
"Microsoft Products are Generally Bug Free"
-- Bill Gates
|
| Back to Top |
|
| |
lupo
SOOP Admins
Joined: 28 August 2008
 Belgium
Posts: 180
|
| Posted: 05 February 2010 at 11:35pm | IP Logged
|
|
|
SVN and patch updated to tinyMCE 3.3b2
As soon as steve is ready patch will be released. and don't push him, he spend enough time on all this lol
__________________
The good thing about reinventing the wheel is that you can get a round one.
|
| Back to Top |
|
| |
AraCam
SOOP Admins
soop admins
Joined: 19 November 2004
United States
Posts: 847
|
| Posted: 12 February 2010 at 12:02pm | IP Logged
|
|
|
I've set this back to open. While we may not be able to fix it from our end, it is certainly still a problem for Soop users.
The update to 3.3b2 on TinyMCE does not resolve this issue.
While the following details may be overkill, I provide them here for thoroughness:
It seems to be caused by not hitting enter at the end of text. In several dozen posts, if I hit enter after typing and then click Reply button, the post comes through cleanly. If I forget to hit Enter (leaving a blank line at the bottom of the post), then that last line / paragraph of text is lost on submission.
This problem affects IE and FF on Win XP, Vista, and Win 7.
The problem occurs prior to the post coming into IIS as a form response. Extensive testing shows that the form response from IIS is already cropped before it comes in. This leads me to think the problem must be buried inside TinyMCE itself.
What amazes me is that no one at Moxie (TinyMCE's creators) seems to be suffering these problems, or at least not to this extent. Is it possible that our implementation of TinyMCE is somehow flawed? (Not the tinymce js itself, but how we connect to it or use it?)
__________________
I'm a database admin. If you see me running, save your work!
{Cranial Herbs & Rice}
|
| Back to Top |
|
| |
AraCam
SOOP Admins
soop admins
Joined: 19 November 2004
United States
Posts: 847
|
| Posted: 12 February 2010 at 12:55pm | IP Logged
|
|
|
This has something to do with whatever part of Tinymce is supposed to close open tags within the text.
IF I type some text, hit Enter, type a few more letters, then go to HTML mode (to reveal the raw html tags), then hit Reply, it's stored correctly, enclosed in <p> </p> tags.
IF I type some text, hit Enter, hit bold button, start typing some bold text, then hit bold btn again, then type some more non-bold text, do NOT hit enter, and hit Reply, the BOLD text on that line is saved, but the non-bold text after it is NOT saved.
Somewhere is a regular expression that's supposed to close the open tags. And that regEx is failing and taking text with it.
__________________
I'm a database admin. If you see me running, save your work!
{Cranial Herbs & Rice}
|
| Back to Top |
|
| |
AraCam
SOOP Admins
soop admins
Joined: 19 November 2004
United States
Posts: 847
|
| Posted: 13 February 2010 at 1:02pm | IP Logged
|
|
|
Literally hours of testing has finally narrowed this problem down to one file.
The forums are being corrupted during processing by
core/jscss/jquery.plugins.js.
I hope to dig into that file later and see if I can figure anything out, but I'm not much of a JS guru, so I'm not sure if I can track the problem down.
In the meantime, I've remmed out the call to this file in core/class_template.asp so my users' posts aren't trashed.
__________________
I'm a database admin. If you see me running, save your work!
{Cranial Herbs & Rice}
|
| Back to Top |
|
| |
AraCam
SOOP Admins
soop admins
Joined: 19 November 2004
United States
Posts: 847
|
| Posted: 14 February 2010 at 2:12pm | IP Logged
|
|
|
I have a possible fix for further testing: Open core/jscss/jquery.plugins.js. Line 100, the jquery form plugin, find this block of text in that line: Code {log('ajaxSubmit: skipping submit process - no element selected');return this}if(typeof u=='function')u={success:u};var add this: Code this += '\n'; So that part of the text looks like: Code {log('ajaxSubmit:
skipping submit process - no element selected');return this}this +=
'\n';if(typeof u=='function')u={success:u};var After
inserting a new line at the end of the form text, I no longer am able
to cause it to drop text. Can anyone else confirm / deny this? I'm
not at my work PC and don't have SVN set up on my home pc. I'll post
this to SVN tomorrow, unless someone else says it remains broken after
this hack. Though I'm not sure this is 100% perfect.
Since doing this change, my site no longer does the "Thanks for your
reply" box. In fact, it also no longer does the "Are you sure?" box
when you delete forum posts, either. So I don't know if that's because
of this hack, or if it's a result of something else I screwed up while
trying to isolate this problem. I will do some more extensive testing on my end in the next two days or so, to make sure this actually fixes it.
If anyone else can confirm / deny this hack, please let me know.
__________________
I'm a database admin. If you see me running, save your work!
{Cranial Herbs & Rice}
|
| Back to Top |
|
| |
AraCam
SOOP Admins
soop admins
Joined: 19 November 2004
United States
Posts: 847
|
| Posted: 15 February 2010 at 12:09pm | IP Logged
|
|
|
Still trying to hack away at this. I've ruled out the basics of ajaxSubmit as the culprit at this point. I've ruled out SQLInjection filtering as well. I know lots and lots of code that's NOT causing this problem. I'm missing something somewhere. When ajaxSubmit gets the forum reply, it already has paragraph tags added to it, and has already lost the end text. I haven't figured out where the data is "cleaned up" prior to ajaxSubmit working on it. Somewhere, those paragraph tags <p>...</p> are added, based on line breaks (enter keys). Once I find that somewhere, I think I can fix this bug for good, but I haven't figured out where that validation occurs.
__________________
I'm a database admin. If you see me running, save your work!
{Cranial Herbs & Rice}
|
| Back to Top |
|
| |
mchilson
Groupie
Joined: 06 March 2005
United States
Posts: 73
|
| Posted: 15 February 2010 at 12:46pm | IP Logged
|
|
|
If I'm not mistaken, isn't there a function in tinyMCE that converts the rich text to HTML?
Could that be the culprit?
|
| Back to Top |
|
| |
AraCam
SOOP Admins
soop admins
Joined: 19 November 2004
United States
Posts: 847
|
| Posted: 15 February 2010 at 1:02pm | IP Logged
|
|
|
Not 100% sure, but the TinyMCE developers assure me that no one else is having this problem. So either we have a unique configuration that's throwing TinyMCE for a loop, or the bug isn't in TinyMCE.
__________________
I'm a database admin. If you see me running, save your work!
{Cranial Herbs & Rice}
|
| Back to Top |
|
| |
ph4nt0m
SOOP Admins
Joined: 03 August 2005
United Kingdom
Posts: 711
|
| Posted: 18 February 2010 at 3:27pm | IP Logged
|
|
|
There is an option in TinyMCE to convert rich text to HTML but we don't actually use it because we do all filtering and conversion server side using the filter class.
__________________
"Microsoft Products are Generally Bug Free"
-- Bill Gates
|
| Back to Top |
|
| |
mchilson
Groupie
Joined: 06 March 2005
United States
Posts: 73
|
| Posted: 19 February 2010 at 4:36am | IP Logged
|
|
|
Ahh... I see.
I got some time today, I think I'll spend it taking a look at the validation process if for no other reason than to help me get my head around it. Trying to get a handle on how the new version works so I can crank out a few mods.
Many thanks guys!
Mike
|
| Back to Top |
|
| |
AraCam
SOOP Admins
soop admins
Joined: 19 November 2004
United States
Posts: 847
|
| Posted: 19 February 2010 at 5:40am | IP Logged
|
|
|
- User clicks Reply, submitting the form via ajaxSubmit (core/jscss/jquery.plugins.js)
- ajaxSubmit does some magic on the forms:
- Sends it out to somewhere (??) for validation.
- Splits the form up into an array of form variables. The text has already been cut by the time it is split.
- Hands the results off to the host.
- IIS receives the form (response.form). The cut has already occurred.
- ASP gets the form and sends it through SQLFilter to make sure there's no attempted SQL Injection attacks.
- The data is then inserted into the forum, provided the user is logged in and/or the captcha passes, and the reply is at least 8 characters in length.
I spent quite a bit of time reversing through this to see where the cut occurs. I've inserted text into the body of the reply in various spots, and have found it's already dropped the original text by the time ajaxSubmit sends it out to a function to be split into an array. That makes me believe the text is lost somewhere during the validation phase.
I suspect the validation includes a regular expression intended to close any open tags (p, b, i, etc.), that's malformed. I just don't know where that test is occurring.
Happy hunting!
__________________
I'm a database admin. If you see me running, save your work!
{Cranial Herbs & Rice}
|
| Back to Top |
|
| |
mchilson
Groupie
Joined: 06 March 2005
United States
Posts: 73
|
| Posted: 19 February 2010 at 9:00am | IP Logged
|
|
|
I was able to duplicate what you did AraCam and also do not see where the validation is occurring. one of the few down sides of oop style code.. chasing a problem when you don't understand the object hierarchy. I looked around through the classes some to and nothing jumped out at me. Maybe one of the developers can tell us. I would like to understand how this is working.
|
| Back to Top |
|
| |
Topic: [CLOSED] Posts corrupted
